Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WG-10: Add projects and user queries. #137

Merged
merged 20 commits into from
Dec 15, 2023
Merged

Conversation

duckonomy
Copy link
Contributor

@duckonomy duckonomy commented Apr 28, 2023

Overview:

Adds basic project and user queries for react.

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Added basic query to userinfo and projects to production geoapi.
Also added slice for projects and modified authSlice to include user information.
Added prettier in npm script.

Testing Steps:

  1. NOTE: Testing is set with production geoapi.
  2. Open page (http://localhost:4200)
  3. Ensure in chrome networks, you see the projects and userinfo responses.

UI Photos:

Notes:

I've tried setting locally with the jwt.. For some reason I get a CORS error for endpoints that should have that covered.

Base automatically changed from task/WG-15-login-logout to master April 28, 2023 16:59
@@ -10,7 +10,9 @@
"test": "jest",
"lint": "npm run lint:js",
"lint:js": "eslint . --ext .js,.jsx,.ts,.tsx",
"lint:fix": "eslint . --ext .js,.jsx,.ts,.tsx --fix"
"lint:fix": "eslint . --ext .js,.jsx,.ts,.tsx --fix",
"prettier:check": "prettier --single-quote --check src",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be added to CI?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -10,7 +10,9 @@
"test": "jest",
"lint": "npm run lint:js",
"lint:js": "eslint . --ext .js,.jsx,.ts,.tsx",
"lint:fix": "eslint . --ext .js,.jsx,.ts,.tsx --fix"
"lint:fix": "eslint . --ext .js,.jsx,.ts,.tsx --fix",
"prettier:check": "prettier --single-quote --check src",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanfranklin nathanfranklin merged commit fbe4f81 into master Dec 15, 2023
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-10-rtk-query branch December 15, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants